Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script] Retrieve proper author and PR type when generating release notes #3746

Open
mimowo opened this issue Sep 5, 2024 · 6 comments
Open
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@mimowo
Copy link

mimowo commented Sep 5, 2024

What would you like to be added:

The release-notes script would retrieve the author of the fix from the parent PR.
Currently, the script retrieves the https://github.com/k8s-infra-cherrypick-robot as the author.

Similarly (less important, because it does not need to be repeated when re-generating notes) it would be great to retrieve the PR type (like kind or feature).

Why is this needed:

It takes time to manually adjust the release notes. Sometimes the notes are regenerated, and in total it can take something like 30min of manual chore. Similarly, we need to manually annotate type for the cherry-picks (/kind bug).

Example release in Kueue: kubernetes-sigs/kueue#2985
For this we have to manually adjust the notes. Example cherry-pick PR: kubernetes-sigs/kueue#2879.

@mimowo mimowo added area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 5, 2024
@mimowo
Copy link
Author

mimowo commented Sep 5, 2024

/cc @alculquicondor

@mimowo mimowo changed the title [script] Retrieve proper author when generating release notes [script] Retrieve proper author and PR type when generating release notes Sep 5, 2024
@mbobrovskyi
Copy link

/assign

@mbobrovskyi
Copy link

mbobrovskyi commented Sep 6, 2024

Looks like we have initial logic to get original PR on #3468. It is not fully cover our problem but it would be great to merge it first.

@mimowo
Copy link
Author

mimowo commented Sep 6, 2024

I see, thank you for letting us know. I'm wondering if we could tidy up the initial pr for the ease of reviewing

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2024
@mimowo
Copy link
Author

mimowo commented Dec 5, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

4 participants