-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add Support for Startup Probe Configuration in default-backend-deployment.yaml #12437
Comments
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I am wondering if you can create your own custom-backend and set that as the default backend. |
@longwuyuan It is difficult to manage the entire Ingress chart as new updates are continuously released. We need this configuration to be included in the chart itself so that we can pull and use it directly. Please consider this request. |
I am confused a bit. Its not about considering a feature yet. I am thinking the startup-probe is for a backend workload. If this is true, then there is no code in the controller for workloads that are used as a backend (even default backend). |
At this time we not actively adding new features as we migrate our focus to ingate. We have discussed at the gateway-api community meeting and our latest ingress-nginx Kubcon Maintainer talk. The repo to following along is at: https://github.com/kubernetes-sigs/ingate |
/help |
@strongjz: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
As we are implementing the startup probe in our application, we observed that the ingress Helm chart in the latest GA version (4.11.3 ) does not include any object for the startup probe. Below is a sample code snippet to configure the startup probe in the default backend. Please consider this as a feature request for an upcoming release:
{{- if .Values.defaultBackend.startupProbe }}
startupProbe:
{{ toYaml .Values.defaultBackend.startupProbe | nindent 12 }}
{{- end }}
The text was updated successfully, but these errors were encountered: