Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Support for Startup Probe Configuration in default-backend-deployment.yaml #12437

Open
Saurabh9552 opened this issue Dec 4, 2024 · 7 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@Saurabh9552
Copy link

Saurabh9552 commented Dec 4, 2024

As we are implementing the startup probe in our application, we observed that the ingress Helm chart in the latest GA version (4.11.3 ) does not include any object for the startup probe. Below is a sample code snippet to configure the startup probe in the default backend. Please consider this as a feature request for an upcoming release:
{{- if .Values.defaultBackend.startupProbe }}
startupProbe:
{{ toYaml .Values.defaultBackend.startupProbe | nindent 12 }}
{{- end }}

@Saurabh9552 Saurabh9552 added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 4, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 4, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@longwuyuan
Copy link
Contributor

I am wondering if you can create your own custom-backend and set that as the default backend.

@Saurabh9552
Copy link
Author

@longwuyuan It is difficult to manage the entire Ingress chart as new updates are continuously released. We need this configuration to be included in the chart itself so that we can pull and use it directly. Please consider this request.

@longwuyuan
Copy link
Contributor

I am confused a bit. Its not about considering a feature yet. I am thinking the startup-probe is for a backend workload. If this is true, then there is no code in the controller for workloads that are used as a backend (even default backend).

@strongjz
Copy link
Member

strongjz commented Dec 4, 2024

At this time we not actively adding new features as we migrate our focus to ingate.

We have discussed at the gateway-api community meeting and our latest ingress-nginx Kubcon Maintainer talk.

The repo to following along is at: https://github.com/kubernetes-sigs/ingate

@strongjz
Copy link
Member

/help

@k8s-ci-robot
Copy link
Contributor

@strongjz:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

4 participants