Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx_ingress_controller_requests are having host data as "_" #12316

Open
ajsmksja opened this issue Nov 6, 2024 · 5 comments
Open

nginx_ingress_controller_requests are having host data as "_" #12316

ajsmksja opened this issue Nov 6, 2024 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@ajsmksja
Copy link

ajsmksja commented Nov 6, 2024

What happened:

We are using customized ingress-nginx v1.10.1. We observed that for few of **nginx_ingress_controller_requests metrics when parsed are having host= __ What could be the possibility/scenario for ingress-nginx to get the host data as "" instead of actual host details.

What you expected to happen:
nginx_ingress_controller_requests{canary="",controller_class="k8s.io/ingress-nginx",controller_namespace="xxxxxxx",controller_pod="xxxxxxxxxxxxxx",host="xxxxxxxxxxxxxxxxxxxxxxxx",ingress="xxxxx",method="POST",namespace="xxxxxx",path="/",service="xxxxxx",status="200"}

But for few of nginx_ingress_controller_requests we are getting host as below as "_"

nginx_ingress_controller_requests{canary="",controller_class="k8s.io/ingress-nginx",controller_namespace="xxxxxxxx",controller_pod="xxxxxxxxxxxxxxxxxxxxxxx",host="_",ingress="xxxxxxx",method="POST",namespace="xxxxxxxx",path="/",service="xxxxx",status="200"}

NGINX Ingress controller version
NGINX Ingress controller
Release: 1.10.1
Build: git-be46124cc
Repository: https://github.com/kubernetes/ingress-nginx.git
nginx version: nginx/1.21.6

Kubernetes version
Client Version: v1.31.2
Kustomize Version: v5.4.2
Server Version: v1.29.1

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Nov 6, 2024
@longwuyuan
Copy link
Contributor

Its not possible to reproduce problems or test a feature, using such an old and unsupported version of the controller.

@ajsmksja
Copy link
Author

ajsmksja commented Nov 7, 2024

Hi @longwuyuan , this was a finding at a server using older version.
latest finding, we are actually facing the same issue with v1.10.1 too and we are in middle of uplifting to v1.11.2
so we believe we are missing something in here.

@sravanith
Copy link

Hi Team ,
As per our finding , we are facing this issue only in few servers, so we think this is not version specific issue, We are also using 1.10.1 and v1.11.2 ingress-nginx , we think this issue might get reproduce here as well. We are looking for possible scenario for having host label data as '_" in nginx_ingress_controller_requests metrics

Copy link

github-actions bot commented Dec 9, 2024

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

@github-actions github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

4 participants