Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support another Ip2info provider #12315

Open
tanoggy opened this issue Nov 6, 2024 · 7 comments
Open

Support another Ip2info provider #12315

tanoggy opened this issue Nov 6, 2024 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@tanoggy
Copy link

tanoggy commented Nov 6, 2024

Support another in2info provider
Can I develop a feature
Support https://ipinfo.io/products/free-ip-database

@tanoggy tanoggy added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Nov 6, 2024
@longwuyuan
Copy link
Contributor

We are trying to deprecate even geoip2 #11669

@tanoggy
Copy link
Author

tanoggy commented Nov 6, 2024

We are trying to deprecate even geoip2 #11669

#11669 is close, can I develop this feature

@longwuyuan
Copy link
Contributor

It will be nice to have it. But we don't want to maintain & support new features. The problem is there are no resources to support/maintain new features. And also many of the features that are super useful are leading to security/stability issues, if they are not part of the core Ingress-API spec.

@longwuyuan
Copy link
Contributor

@tanoggy I saw just now that the free datatype for ipinfo.io has at least this much

Free
{
  "ip": "211.197.11.0",
  "city": "Kyosai",
  "region": "Gyeongsangnam-do",
  "country": "KR",
  "loc": "34.8503,128.5886",
  "org": "AS4766 Korea Telecom",
  "postal": "53285",
  "timezone": "Asia/Seoul",
  "tags": []
}

You can join the community meetings and ask if there is interest in a PR for this https://github.com/kubernetes/community/tree/master/sig-network

@abdullahdevrel
Copy link

Thanks @tanoggy I work for IPinfo, and I really appreciate the feature request!

For context, our free IP database comes in various formats, with the IP to Country ASN database being one of the most popular. It includes features such as:

  • It includes country and ASN information in the same database.
  • It is updated daily, with zero compromise to accuracy. There is no range clustering, and the database provides full accuracy.
  • The data granularity reaches individual IP level.
  • The database comes in MMDB database format.
  • It is licensed under CC-BY-SA 4.0, permitting commercial usage.
  • Available file formats include: CSV, MMDB, JSON
  • The data is tabular and unnested, making it very easy to use. The dataset includes both IPv4 and IPv6 in a single file.

Database schema

Field Name Example Data Type Description
start_ip 1.0.16.0 TEXT Starting IP address of an IP address range
end_ip 1.0.31.255 TEXT Ending IP address of an IP address range
country JP TEXT ISO 3166 country code of the location
country_name Japan TEXT Name of the country
continent AS TEXT Continent code of the country
continent_name Asia TEXT Name of the continent
asn AS2519 TEXT Autonomous System Number
as_name ARTERIA Networks Corporation TEXT Name of the AS (Autonomous System) organization
as_domain arteria-net.com TEXT Official domain or website of the AS organization

Documentation: https://ipinfo.io/developers/ip-to-country-asn-database

Copy link

github-actions bot commented Dec 9, 2024

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

@github-actions github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

4 participants