Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support declarative API for validation rules for external admission checks #3106

Open
3 tasks
mimowo opened this issue Sep 20, 2024 · 0 comments
Open
3 tasks
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mimowo
Copy link
Contributor

mimowo commented Sep 20, 2024

What would you like to be added:

We already have two validation rules for admission checks, used for the built-in ones:

  • SingleInstance - means that only one instance of the AdmissionCheck can be specified for CQ
  • FlavorIndependent - meaning that the AdmissionCheck can only be specified at the CQ level

Both of them are used currently for MultiKueue only.

Why is this needed:

To provide declarative validation of the AdmissionCheck configuration for the external AdmissionChecks.

This is a spin off from the discussion under #3094.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@mimowo mimowo added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant