eliminate all instances of default
filter in roles => var should have a default defined only once
#11822
Labels
good first issue
Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
We have lots of instances of this pattern:
Where the same value is repeated multiples places in the code base
-> that default should be defined only once.
We should instead define those defaults in roles defaults/ directories, either
Where possible, the default definition should also be accompanied by a comment defining the use of the variable, and possibly a commented examples for variable with a complex internal structure.
The two benefits:
default
filters(by the way, this also apply to variable which we check with
is defined
-> we shouldn't have to do that if we define a default)There is no need to tackle every instance at once, but this is pretty good way to start working on the code base for new contributors.
/help
/good-first-issue
The text was updated successfully, but these errors were encountered: