Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Image plugin when used in other tools has been tracked with Kubebuilder domain #3576

Open
camilamacedo86 opened this issue Aug 29, 2023 · 4 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@camilamacedo86
Copy link
Member

What broke? What's expected?

See: https://github.com/operator-framework/operator-sdk/blob/master/testdata/go/v4-alpha/monitoring/memcached-operator/PROJECT#L5-L21

By extending the plugin in another tool, i.e.:

deployImageBundle, _ := plugin.NewBundleWithOptions(
		plugin.WithName("deploy-image."+"my-domain"),
		plugin.WithVersion(plugin.Version{Number: 1, Stage: stage.Alpha}),
		plugin.WithPlugins(
			deployimagev1alpha.Plugin{},
		),
	)

I would expected the PROJECT file tracked it as my own plugin domain informed. Instead it is not using the name informed and still tracking it as deploy-image.go.kubebuilder.io/v1-alpha

Reproducing this issue

No response

KubeBuilder (CLI) Version

master

PROJECT version

No response

Plugin versions

No response

Other versions

No response

Extra Labels

No response

@camilamacedo86 camilamacedo86 added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 29, 2023
@lowang-bh
Copy link
Member

/assign

@camilamacedo86 camilamacedo86 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Sep 4, 2023
@camilamacedo86
Copy link
Member Author

Hi @lowang-bh ,

Are you working in this one? If so, please, feel free to ping us if you face any challenge to achieve this one. If not, please unassigned it from you so others might able to work on it.

Thank you a lot for all your contributions 🥇 and help in make kubebuilder better for the community.

@lowang-bh lowang-bh removed their assignment Nov 17, 2023
@yyy1000
Copy link
Member

yyy1000 commented Dec 25, 2023

I want to make sure I understand this issue, so it's like:

b, _ := plugin.NewBundleWithOptions(
		plugin.WithName("deploy-image."+"my-domain"),
		plugin.WithVersion(plugin.Version{Number: 1, Stage: stage.Alpha}),
		plugin.WithPlugins(
			v1alpha1.Plugin{},
		),
	)
	deploy := b.Plugins()[0]
	print(deploy.Name())

The result I got here is 'deploy-image.go.kubebuilder.io%', but should be 'deploy-image.my-domain'?

/assign

@camilamacedo86
Copy link
Member Author

Yes, that is the issue 👍

@camilamacedo86 camilamacedo86 added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants