Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs ENV error #3717

Open
Kaeldara-ru opened this issue Apr 22, 2024 · 5 comments · May be fixed by #3720
Open

Docs ENV error #3717

Kaeldara-ru opened this issue Apr 22, 2024 · 5 comments · May be fixed by #3720

Comments

@Kaeldara-ru
Copy link

KATIB_POSTGRESQL_DATABASE - Wrong. In sources Env is KATIB_POSTGRESQL_DB_DATABASE

https://github.com/kubeflow/katib/blob/master/pkg/db/v1beta1/common/const.go
@hbelmiro
Copy link
Contributor

@Kaeldara-ru can you point out where in the docs this is wrong?
Also, feel free to send a PR to fix it.

@Kaeldara-ru
Copy link
Author

@Kaeldara-ru can you point out where in the docs this is wrong? Also, feel free to send a PR to fix it.

https://github.com/kubeflow/katib/blob/2d308b72c3b4ed6f1365d7c6002a307386a8d252/pkg/db/v1beta1/common/const.go#L43

On this line parse another env. KATIB_POSTGRESQL_DATABASE - not implemented. I'll check releases branches -> current main. All time was KATIB_POSTGRESQL_DB_DATABASE

@andreyvelich
Copy link
Member

Thank you for reporting this @Kaeldara-ru!
You are right, please can you create a PR to fix this guide ?

@andreyvelich
Copy link
Member

cc @kubeflow/wg-automl-leads

Kaeldara-ru added a commit to Kaeldara-ru/website that referenced this issue Apr 23, 2024
@Kaeldara-ru
issues-3717 | Fix env-variables.md
8d86535 
https://github.com/kubeflow/katib/blob/2d308b72c3b4ed6f1365d7c6002a307386a8d252/pkg/db/v1beta1/common/const.go#L43

On this line parse another env. KATIB_POSTGRESQL_DATABASE - not implemented. I'll check releases branches -> current main. All time was KATIB_POSTGRESQL_DB_DATABASE

kubeflow#3717
@Kaeldara-ru Kaeldara-ru linked a pull request Apr 23, 2024 that will close this issue
Open
@Kaeldara-ru
Copy link
Author

#3720

PR created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Needs Triage
Status: To Do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes: #3717 Kaeldara-ru/website
3 participants
@hbelmiro @andreyvelich @Kaeldara-ru