Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Use kubeflow-system namespace for the Kubeflow Control Plane #2937

Open
5 of 7 tasks
andreyvelich opened this issue Dec 19, 2024 · 5 comments
Open
5 of 7 tasks

Comments

@andreyvelich
Copy link
Member

andreyvelich commented Dec 19, 2024

Validation Checklist

  • Is this a Kubeflow issue?
  • Are you posting in the right repository ?
  • Did you follow the Kubeflow installation guideline ?
  • Is the issue report properly structured and detailed with version numbers?
  • Is this for Kubeflow development ?
  • Would you like to work on this issue?
  • You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Version

master

Describe your issue

I proposed during the previous Kubeflow Community meeting that we rename namespace from kubeflow to kubeflow-system. So we make the kubeflow-system - the default namespace for the Kubeflow control plane.

The motivation is to make it easier for cluster admins to understand that the Kubeflow control plane is deployed in this namespace, and make Kubeflow consistent with other CNCF projects. For example:

  • Kubernetes: kube-system
  • Istio: istio-system
  • Kueue: kueue-system

FYI, @kubeflow/wg-training-leads are already using the kubeflow-system namespace for Kubeflow Training V2.

WDYT @kubeflow/wg-manifests-leads ?

Put here any screenshots or videos (optional)

No response

@terrytangyuan
Copy link
Member

+1 but shouldn’t the namespace be configurable?

@thesuperzapper
Copy link
Member

I like the idea of making it configurable, or even having separate ones like kubeflow-pipelines and kubeflow-notebooks as there is not really a reason to combine everything, and this just increases security risk (stuff like dashboard and profile controller could be in kubeflow-system).

However, this is going to be a crazy amount of work, because we hard code the kubeflow namespace everywhere, including places where it will be hard to template, like Istio configs.

@andreyvelich
Copy link
Member Author

1 but shouldn’t the namespace be configurable?

@terrytangyuan I think, we should make this namespace configurable. I just meant that by default we can use the kubeflow-system namespace in the Kubeflow Manifests.

However, this is going to be a crazy amount of work, because we hard code the kubeflow namespace everywhere, including places where it will be hard to template, like Istio configs.

We don't hard code the Kubeflow namespace everywhere. For example, we allow to configure namespace for:

@juliusvonkohout
Copy link
Member

I am in favour of renaming it and it sounds like something for Gsoc 2025.

@thesuperzapper
Copy link
Member

Although, if we are only making this change for stylistic reasons, I am not sure it's worth it, because it's a breaking change which will reduce the amount of people who upgrade.

Doing a split up by app has other benefits so I am more open to it, but still hesitant to do anything that will make upgrades harder for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants