Improve Debuggability in UTs of Trial Controller

[Electronic-Waste]

What you would like to be added?

Use the propagated gomega instance in replace of func() bool, like code here:

katib/pkg/controller.v1beta1/trial/trial_controller_test.go

Lines 303 to 314 in bc09cfd

	// Expect that Trial status is succeeded with "false" status and "metrics unavailable" reason.
	// Metrics unavailable because GetTrialObservationLog returns "unavailable".
	g.Eventually(func() bool {
	if err = c.Get(ctx, trialKey, trial); err != nil {
	return false
	}
	return trial.IsMetricsUnavailable() &&
	len(trial.Status.Observation.Metrics) > 0 &&
	trial.Status.Observation.Metrics[0].Min == consts.UnavailableMetricValue &&
	trial.Status.Observation.Metrics[0].Max == consts.UnavailableMetricValue &&
	trial.Status.Observation.Metrics[0].Latest == consts.UnavailableMetricValue
	}, timeout).Should(gomega.BeTrue())

Why is this needed?

As @tenzen-y described in #2394 (comment), it will improve the debuggability of the UTs.

Love this feature?

Give it a 👍 We prioritize the features with most 👍

[Electronic-Waste]

/area testing
/good-first-issue
/remove-label lifecycle/needs-triage

[google-oss-prow]

@Electronic-Waste:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/area testing
/good-first-issue
/remove-label lifecycle/needs-triage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Electronic-Waste]

/assign

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Electronic-Waste]

/remove-lifecycle stale

This issue and related PR are ready to be reviewed. PTAL if you have time @kubeflow/wg-automl-leads .