Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace go mock with client-go fake client in unit tests #2408

Open
tariq-hasan opened this issue Aug 18, 2024 · 6 comments
Open

Replace go mock with client-go fake client in unit tests #2408

tariq-hasan opened this issue Aug 18, 2024 · 6 comments
Assignees
Labels
area/testing good first issue Good for newcomers help wanted Extra attention is needed kind/feature

Comments

@tariq-hasan
Copy link
Contributor

What you would like to be added?

go mock should be replaced with client-go fake client in unit tests.

Why is this needed?

Reference: #2289 (comment)

Love this feature?

Give it a 👍 We prioritize the features with most 👍

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

/remove-lifecycle stale
/good-first-issue
/remove-label lifecycle/needs-triage
/area testing

Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/remove-lifecycle stale
/good-first-issue
/remove-label lifecycle/needs-triage
/area testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deveshidwivedi
Copy link

Hi, can I take this up?

@tenzen-y
Copy link
Member

Hi, can I take this up?

Feel free to take this one with /assign.

@deveshidwivedi
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing good first issue Good for newcomers help wanted Extra attention is needed kind/feature
Projects
None yet
Development

No branches or pull requests

4 participants