Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [RULES] False positive on "Stream#close() must be called explicitly to close the underlying resources" hibernate6-00090 #656

Open
1 task done
abrugaro opened this issue Jul 15, 2024 · 2 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@abrugaro
Copy link
Contributor

abrugaro commented Jul 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.5 beta 1

Anything else?

Tested with Kantra b0.5 beta1
Target: eap8 (and others)
Source: none
Source code used: https://github.com/sonatype/nexus-public
Rule triggered: hibernate6-00090 Stream#close() must be called explicitly to close the underlying resources
Report: https://drive.google.com/file/d/1TbdLS4_728DgxbB88F7YcXw84jK2elty/view?usp=drive_link

This rule reported 8 incidents for the application, all of them were related to streams out of the hibernate package and none of them needed to be closed as they were either inline calls to stream() on Collections or I/O operations inside try-with-resource blocks

image
image
image

@abrugaro abrugaro added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 15, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Jul 15, 2024
@jmle jmle self-assigned this Jul 17, 2024
@jmle
Copy link
Contributor

jmle commented Jul 24, 2024

This gets partially fixed with konveyor/rulesets#95. There is still one rogue false positive that needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants