Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): add support for whatsapp #62

Closed
matbgn opened this issue Mar 31, 2022 · 7 comments
Closed

feat(service): add support for whatsapp #62

matbgn opened this issue Mar 31, 2022 · 7 comments
Labels
feature Support for new feature good first issue Good for newcomers up for grabs This is available for contribution

Comments

@matbgn
Copy link

matbgn commented Mar 31, 2022

Adding Whatsapp will be absolutely awesome.

Describe the solution you'd like

Based on the Notify service would it be possible to do this without huge work?
https://github.com/nikoksr/notify/tree/main/service/whatsapp

@kha7iq kha7iq added good first issue Good for newcomers feature Support for new feature up for grabs This is available for contribution labels Apr 1, 2022
@kha7iq
Copy link
Owner

kha7iq commented Apr 19, 2022

Closing this as its not possible with current implementation whatsapp with Notify.

@kha7iq kha7iq closed this as completed Apr 19, 2022
@matbgn
Copy link
Author

matbgn commented May 9, 2022

Seeing all pour inputs, what will be the requirements to make it happen?

In other words what would be the macro steps to link PingMe CLI > Notify > WhatsApp ?

@kha7iq
Copy link
Owner

kha7iq commented May 10, 2022

A PR was already opened by Kristina Kupreeva, untill the issue with whatsapp API is not fixed neither directly nor with Notify we can implement this.
Have a look at the comment here : #63 (comment)

@matbgn
Copy link
Author

matbgn commented May 10, 2022

Thank you for your quick answer. Did notice Kristina's work but wasn't really sure of were layed the problem at the end. Seems clearer now, so we just have to be patient or take a look at this API implementation.

@matbgn
Copy link
Author

matbgn commented May 10, 2022

Is there any chance to bridge PingMe directly with the Go library proposed as replacement? Or are we strongly binded with Notify?

Warning
This package is not being actively maintained currently and will soon be unusuable as WhatsApp updates to multi-device. Please look at tulir/whatsmeow for a Go WhatsApp Web API that is actively maintained and supports WhatsApp multi-device.

@kha7iq
Copy link
Owner

kha7iq commented May 12, 2022

It is possible we already have a few services which do not use notify for integration.

@matbgn
Copy link
Author

matbgn commented May 12, 2022

OK thanks, good to know for the future also. In the mean time Niko Köser from Notify responded to my question about switching to another WhatsApp library. It seems that it is on his highest priority list, so we will first wait a few months before going any further:

@matbgn thank you very much for the report! And sorry for the inconvenience. I definitely want to keep the WhatsApp service alive, so I or someone else will take care of it as soon as possible.

nikoksr/notify#274 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Support for new feature good first issue Good for newcomers up for grabs This is available for contribution
Projects
None yet
Development

No branches or pull requests

2 participants