Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tips for making extension building optional #49

Open
djhoese opened this issue Apr 18, 2019 · 1 comment
Open

Tips for making extension building optional #49

djhoese opened this issue Apr 18, 2019 · 1 comment

Comments

@djhoese
Copy link

djhoese commented Apr 18, 2019

I recently updated the vispy jupyter extension to work with modern notebook/jlab and got everything to work for the extension. However, since vispy is not "just" a jupyter extension we're now running in to issues installing the package from github (from source). The related issue is vispy/vispy#1619. It seems related mostly to users either not having npm installed or not having a recent version (at least that's my guess).

I've been trying to think of the best way to handle this and was hoping people here could give me other suggestions. My top solution so far is to add the static/*.js files to the repository. Other ideas?

Or...am I doing something wrong in vispy's setup.py and this is supposed to work the way I need.

@vidartf
Copy link
Member

vidartf commented Oct 15, 2019

The ideal solution here would probably be to update the cookiecutter to rely on PEP518, and specify a build time dependency on jupyter_packaging. When used correctly, that package helps ensure that both the sdist and bdist_wheel include the built JS, so that node is only required for jupyterlab or development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants