Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revap errors again ? #11

Open
judg393 opened this issue Nov 7, 2022 · 40 comments
Open

revap errors again ? #11

judg393 opened this issue Nov 7, 2022 · 40 comments

Comments

@judg393
Copy link

judg393 commented Nov 7, 2022

Hi JTS

hope your well

I've no idea what ive done but i appear to be having problems again with revamp and your Production Inspector ?

animals and silo seems to work but productions cause errors :(

20221107224012_1
20221105215612_1
log.txt

@judg393
Copy link
Author

judg393 commented Dec 4, 2022

I tried to roll back to the version you sent me last time i had issues but i'm still haveing issues :( possibly a revamp update?
strangley animal works fine

@jtsage
Copy link
Owner

jtsage commented Dec 4, 2022

I'll try and spend some time on this one today. I've been spending far too much time in MP lately, and this isn't one of the ones we use, so it's a bit lower on my radar.

Thanks for letting me know.

@judg393
Copy link
Author

judg393 commented Dec 4, 2022

ah no worries mate I wasnt sure if you were even supporting this still :/
Its doing it on Silver R too

@judg393
Copy link
Author

judg393 commented Dec 13, 2022

Mentioned on discord but this

#9 (comment)

seems to have cleared the error I'm not sure what I should be able to see (is that what the factory is producing?) but it's a definitely cleared my errors and made PI (love that shortening) show up again :)

@judg393
Copy link
Author

judg393 commented Jan 4, 2023

Did you get anywhere with this? Anything I can do to help? Not a coder but happy to test things :)

@BullFlag
Copy link

BullFlag commented Jan 5, 2023

@judg393 I did remove FS22_A_ProductionRevamp and that cleared the buggy behavior with Production Inspector... No longer needed option "Show Outputs" set to NO.

Log showing if Show Outputs set to YES ....ProductionInspector.lua:815: attempt to concatenate a nil value
2023-01-05 08:36 Error: Running LUA method 'draw'.

@judg393
Copy link
Author

judg393 commented Jan 7, 2023

Aye unfortunately I really like PR :/ I mean PI does work so I'll just be patient. 😀

@jtsage
Copy link
Owner

jtsage commented Jan 7, 2023

I have been trying to get back to this, I'll try and move it up my priority list a bit more. Too many projects, not enough hours in the day :)

@judg393
Copy link
Author

judg393 commented Jan 7, 2023

Of course sorry! I really appreciate your time :)

@jtsage
Copy link
Owner

jtsage commented Jan 8, 2023

FS22_ProductionInspector.zip

Give this version a shot, would ya?

@BullFlag
Copy link

BullFlag commented Jan 8, 2023

I'll try it with the new Beta of Revamp also Thanks Yes the fix works with current and new Beta for Revamp .

Awesome work
Have PI Outputs option ON and no more error or miss behavior PI and Revamp appear fully compatible Thanks

2023-01-07 16_44_36-Revamp Scriptmod - LS Mapping Team   LSMT Modding Team and 3 more pages - Person

@jtsage
Copy link
Owner

jtsage commented Jan 8, 2023

Cool. I have several things on my "want to do" list with this - there were some massive improvements that got as far as simpleinspector, but not this, gonna deadicate most of tomorrow to them, and hopefully push a new version to modhub / release page here

@judg393
Copy link
Author

judg393 commented Jan 10, 2023

Jts you are a legend ;) thanks dude it's working for me too

@jtsage
Copy link
Owner

jtsage commented Jan 11, 2023

If either of you get particularly bored, this is a beta of 1.2.0.0 - assuming I didn't break anything, it will get pushed to modhub in the next few days.

@BullFlag
Copy link

Beta 1.2... All looks good Only Noticed Silo item "Top Right under Clock" setting bit buggy, Didn't take setting change I made , flip back to previous. Tried saving each change no difference

@jtsage
Copy link
Owner

jtsage commented Jan 12, 2023

As it happens, none of the display mode settings worked. Fixed in this one.

FS22_ProductionInspector.zip

@jtsage
Copy link
Owner

jtsage commented Jan 12, 2023

Closing as the fixed version hit modHub about 20min ago. Feel free to reopen if I missed something

@jtsage jtsage closed this as completed Jan 12, 2023
@judg393
Copy link
Author

judg393 commented Jan 16, 2023

20230116204106_1
log.txt

OK What am i doing wrong :(

image

Could it be something to do with this? :(

@jtsage
Copy link
Owner

jtsage commented Jan 16, 2023

Hmm. The folder switcher display is perplexing to me, lemme run down why that might happen. (Can you check to see if you have both the ZIP and an unzipped version in your collections somewhere (at a guess, in "The Oaks") - that might do it) - The only time the "same" mod should be able to appear twice is if it is both zipped and unzipped. I hope :)

As to the error and blank display - correct me if I'm wrong, but it looks like you have productions and silo both displaying in mode 1 (under the help menu). Do you by chance not own any productions, or not have any working? Or maybe not have any silos with anything in them? It's getting hung up on bit that stacks the different display elements neatly, but before I go in and do a ton of checks to catch nil errors, I'd like to be able to reproduce locally.

Thanks!

@jtsage jtsage reopened this Jan 16, 2023
@judg393
Copy link
Author

judg393 commented Jan 17, 2023

The folder and zip thing is likely I was testing using GitHub's desktop app for mod updates. I'll check it.

Regarding PI I own 1 manure factory but it's not running anything and apparently I own a warehouse that's baked into map again not in use.

I haven't messed with my positioning yet so yes it's likely PI and SI (I don't own or have anything stored in the map silos afaik but they do show up) should I try and change the positioning of thr Insp. windows

I'm really sorry I feel like you put in all this work and I just break things 🙈

@judg393
Copy link
Author

judg393 commented Jan 23, 2023

Ok I'm an idiot moved the windows around and bobs your uncle

@jtsage
Copy link
Owner

jtsage commented Jan 23, 2023

cool. i've not yet circled back to this, but that is what I thought might be the issue. There are some math operations in use where the value should always be defined, except apparently it is not. I'll drop some extra checks to get it to not error on this, and perhaps I'll stumble across what is actually causing it.

@judg393
Copy link
Author

judg393 commented Jan 24, 2023

Thank you and sorry to cause problems 🙈🤦‍♂️

@jtsage
Copy link
Owner

jtsage commented Jan 26, 2023

I threw in a few extra checks that should keep this from happening. Also, I added unitConvert (or something close to it) to the mod. It's the ZIP in the repository, gonna give it a go tonight and tomorrow before I push to modHub again.

@judg393
Copy link
Author

judg393 commented Jan 26, 2023

Ooo what's unit convert 😂 I love how much you build into your mods I will tie a knot in my neck to grab latest and replace also the release on GH seems to be 1.2 still?

@jtsage
Copy link
Owner

jtsage commented Jan 26, 2023

UnitConvertLite is/was a mod by ThundR in the 19 days, it has been ported over to 22 - some of his choices I like, and some I don't - most of those I don't were based on the limitations of 19, and I understand a new version is being worked on, looking forward to it.

But, unitConvert does just that - it'll display volume or weight in whatever unit you prefer. Would you like to know how much wheat is in your trailer, in metric tons? It'll do that. How many gallons of water in the tanker? It'll do that too.

And yes, I have not pushed a "real" release yet, probably today - usually this file : https://github.com/jtsage/FS22_ProductionInspector/blob/main/FS22_ProductionInspector.zip is the most recent.

@judg393
Copy link
Author

judg393 commented Jan 27, 2023

Ok I'm using the new file I'll see what I find. I can see it's added a whole load of info to the bottom of my f1 menu. Hope it doesn't interfere with lumberjack.

@BullFlag
Copy link

BullFlag commented Jan 27, 2023

2023-01-27 08_28_53-Farming Simulator 22
The adding in the Unit Convert is a genius improvement. Running that all the time now With limited use all looking good with 1.4 Beta 15 Revamp..

@judg393
Copy link
Author

judg393 commented Jan 29, 2023

I agree no issues here though I'm gonna be honest not sure I'm gonna use unit convert aspect it's not broken anything (and I haven't either 😬)

@jtsage
Copy link
Owner

jtsage commented Jan 29, 2023

Haha. I mostly agree with you there. I don't have a good visual understanding of how much grain 1l is, but that number in bushels sure doesn't help me more.

@judg393
Copy link
Author

judg393 commented Jan 31, 2023

Welp revamp updated yesterday and appears to have broken PI again image

Was working great until I turned the production on (modified manure factory) turning off outputs makes text visible again and afaik everything is in its own corner

@jtsage
Copy link
Owner

jtsage commented Jan 31, 2023

Cool. I've actually been holding the latest update because I knew that was coming. I'll take a look later today.

@judg393
Copy link
Author

judg393 commented Jan 31, 2023

thats forward planning can i just confirm what version i should be using i seemto have 1.2.0.1???

@jtsage
Copy link
Owner

jtsage commented Jan 31, 2023

Latest here is https://github.com/jtsage/FS22_ProductionInspector/releases/tag/v1.2.0.2

But if it's related to the outputs, 1.2.0.2 probably won't fix it. I need to make the section a bit more bulletproof.

@judg393
Copy link
Author

judg393 commented Jan 31, 2023

I just want to make sure im running the latest version atm 👍

@judg393
Copy link
Author

judg393 commented Jan 31, 2023

i know you'll fix what you can when you can

@jtsage
Copy link
Owner

jtsage commented Feb 2, 2023

FS22_ProductionInspector.zip

Give this one a shot. Loaded up fine for me with a couple productions on a map and revamp installed, but who knows. If it does it again, can you drop your game log here too? Thanks!

@judg393
Copy link
Author

judg393 commented Feb 7, 2023

Ooo just seen this will try now

@judg393
Copy link
Author

judg393 commented Feb 7, 2023

We'll blow me whatever you did worked :) thanks mate

@FirenzeIT
Copy link

FirenzeIT commented Dec 14, 2023

Yes, always errors for me too with (and sometimes without) revamps addon :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants