Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Business Hours Check Extension Method #184

Open
AhmedFaizanDev opened this issue Jul 30, 2024 · 7 comments
Open

Add Business Hours Check Extension Method #184

AhmedFaizanDev opened this issue Jul 30, 2024 · 7 comments

Comments

@AhmedFaizanDev
Copy link

Description:
We could implement a new extension method IsWithinBusinessHours for the DateTime class. This will help check if a specific DateTime falls within a given range of business hours. The method should take startTime and endTime as TimeSpan parameters and return true if the DateTime is between them.

Example Method Signature:

bool IsWithinBusinessHours(this DateTime dateTime, TimeSpan startTime, TimeSpan endTime)

This feature would be handy for checking if a time is during standard working hours. It could be used in scheduling systems or for customer support hours.

Example Usage:

DateTime now = DateTime.Now;
bool isWithinBusinessHours = now.IsWithinBusinessHours(new TimeSpan(9, 0, 0), new TimeSpan(17, 0, 0));

if (isWithinBusinessHours)
{
    Console.WriteLine("The current time is within business hours.");
}
else
{
    Console.WriteLine("The current time is outside business hours.");
}
Repository owner deleted a comment from Dave7261 Aug 4, 2024
Repository owner deleted a comment from AhmedFaizanDev Aug 4, 2024
@PASSIONFORYOU
Copy link

Hi,
The proposed extension method IsWithinBusinessHours for the DateTime class checks if a specific DateTime falls within a defined range of business hours. Here's a concise overview:

Method Signature:

bool IsWithinBusinessHours(this DateTime dateTime, TimeSpan startTime, TimeSpan endTime)

Purpose:

This method helps determine if a given time is during standard working hours, useful for scheduling or customer support systems.

Example Usage:

DateTime now = DateTime.Now;
bool isWithinBusinessHours = now.IsWithinBusinessHours(new TimeSpan(9, 0, 0), new TimeSpan(17, 0, 0));

if (isWithinBusinessHours)
{
    Console.WriteLine("The current time is within business hours.");
}
else
{
    Console.WriteLine("The current time is outside business hours.");
}

Hope help. ^-^

@AhmedFaizanDev
Copy link
Author

Hi, The proposed extension method IsWithinBusinessHours for the DateTime class checks if a specific DateTime falls within a defined range of business hours. Here's a concise overview:

Method Signature:

bool IsWithinBusinessHours(this DateTime dateTime, TimeSpan startTime, TimeSpan endTime)

Purpose:

This method helps determine if a given time is during standard working hours, useful for scheduling or customer support systems.

Example Usage:

DateTime now = DateTime.Now;
bool isWithinBusinessHours = now.IsWithinBusinessHours(new TimeSpan(9, 0, 0), new TimeSpan(17, 0, 0));

if (isWithinBusinessHours)
{
    Console.WriteLine("The current time is within business hours.");
}
else
{
    Console.WriteLine("The current time is outside business hours.");
}

Hope help. ^-^

Hey! Thanks for the summary and If there's anything more to clarify, I'm happy to help. Otherwise, I'd be more than willing to contribute by implementing this feature and submitting a pull request if you’d like.

Looking forward to your thoughts!

Repository owner deleted a comment from Harshhrc Oct 24, 2024
Repository owner deleted a comment from Harshhrc Oct 24, 2024
@Dan-613
Copy link

Dan-613 commented Nov 8, 2024

How would you handle if the business is closed on Saturdays and Sundays?
The proposed extension only looks at the time.

@github-roushan
Copy link
Contributor

Is this issue resolved. Anyone?

@joaomatossilva
Copy link
Owner

Is this issue resolved. Anyone?

I still don't even know what the problem is. Maybe with a Unit test showing the expected result could help clear things up

@josiahwelch
Copy link

I am sure this can be closed... there is test coverage for the extension in BusinessHoursTests.cs

@github-roushan
Copy link
Contributor

Ok I am taking a look into it and will close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants