Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with dashses in unquoted strings #67

Open
GrahamCampbell opened this issue Jul 14, 2020 · 2 comments
Open

Bug with dashses in unquoted strings #67

GrahamCampbell opened this issue Jul 14, 2020 · 2 comments

Comments

@GrahamCampbell
Copy link

GrahamCampbell commented Jul 14, 2020

The following query:

data.relationships.flow-actions.data[].id

is invalid syntax according to the specification, because dashes are not allowed in unquoted strings, however this library allows it. I guess we are missing a spec compliance test that asserts there's a parse error. FYI, the PHP implementation is correct, and rejects that input.

The origin of this report is jmespath/jmespath.php#57 (comment).

@bespokebob
Copy link

It seems like this is fixed in 0.15.0, but https://jmespath.org/ is using 0.14.0.
This just needs to be fixed in https://github.com/jmespath/jmespath.site

bespokebob added a commit to bespokebob/jmespath.site that referenced this issue Feb 17, 2021
The site is using 0.14.0, but the latest version 0.15.0 fixes at least one bug.

Fixes jmespath/jmespath.js#67
springcomp pushed a commit to jmespath-community/jmespath.site that referenced this issue Feb 18, 2022
The site is using 0.14.0, but the latest version 0.15.0 fixes at least one bug.

Fixes jmespath/jmespath.js#67
springcomp pushed a commit to springcomp/jmespath.site that referenced this issue May 25, 2022
The site is using 0.14.0, but the latest version 0.15.0 fixes at least one bug.

Fixes jmespath/jmespath.js#67
@springcomp
Copy link

@youngbob For the record, JMESPath Community site uses the latest version of the JavaScript implementation.

The corresponding pull request has also been accepted recently on the official site. Unfortunately, it has yet to be deployed to take effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants