You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've been using django-waffle quite a lot, and noticed that inherited child classes aren't able to flip the switch state overridden in a given parent class. This behaviour is the case for django's override_settings and was added around 2013, this means that we often assume django-waffle has the same behaviour. The implementation idea below borrows some similar features.
We've done some work in this commit and will briefly summarise the expected behaviour below:
@override_switch('foo', active=False)
class ParentTestClass(TestCase):
pass
@override_switch('foo', active=True)
class ChildTestCase(ParentTestCase):
def test_switch_state(self):
# I expect this to be true
self.assertTrue(waffle.switch_is_active('foo'))
What are your thoughts on this addition?
The text was updated successfully, but these errors were encountered:
Hello,
We've been using django-waffle quite a lot, and noticed that inherited child classes aren't able to flip the switch state overridden in a given parent class. This behaviour is the case for django's
override_settings
and was added around 2013, this means that we often assume django-waffle has the same behaviour. The implementation idea below borrows some similar features.We've done some work in this commit and will briefly summarise the expected behaviour below:
What are your thoughts on this addition?
The text was updated successfully, but these errors were encountered: