You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Django 4.2 added support for async m2m manipulation directly via aadd, aset, aclear, aremove. Since taggit is based in that API it would be nice to also support it.
For now we can just:
from channels.db import database_sync_to_async
[...]
await database_sync_to_async(mymodel.tags.add)('mytag')
The text was updated successfully, but these errors were encountered:
Not sure what we need to do exactly here, I would hope that models.Manager would get us this "for free", but seems like it might not. We'll likely need to do some work to add some tests on this front as well. Bit of a chill weekend commit, probably!
I think it would make sense for us to add async variants to methods like add and set and remove on _TaggableManager (in taggit/managers.py) that just do a similar sync_to_async strategy like above (with similar naming).
Doing that should "just work" according to my reading of how all this stuff works.
Django 4.2 added support for async m2m manipulation directly via
aadd
,aset
,aclear
,aremove
. Since taggit is based in that API it would be nice to also support it.For now we can just:
The text was updated successfully, but these errors were encountered: