You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My point is that previously it was possible to handle the output of different Device (ie: WebpushDevice and GCMDevice) with the same code because they were returning dict/list[dict] according if you were calling the method on a single instance or on the queryset.
Now the code should be reworked to hande the BatchResponse from firebase SDK.
My question is: is this project willing to keep a common API for .send_message output or is it letting any device kind to provide a different output for such method?
The implementation with firebase SDK has changed the output of the
send_message
methodBefore it was a
dict
django-push-notifications/push_notifications/gcm.py
Lines 202 to 204 in 7d28052
Now it is a
BatchResponse
django-push-notifications/push_notifications/gcm.py
Lines 188 to 190 in 0f79181
This means that any code which relies on the output to be a dict now need to work-around the new type.
This is a breaking change which should have been highlighted or avoided.
The text was updated successfully, but these errors were encountered: