Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings variable name conflict #734

Open
dedayoa opened this issue Nov 16, 2020 · 1 comment
Open

Settings variable name conflict #734

dedayoa opened this issue Nov 16, 2020 · 1 comment

Comments

@dedayoa
Copy link

dedayoa commented Nov 16, 2020

I'm using both django-pipeline and django-social-auth. It turns out that djano-social-auth has a setting discovery mechanism that attempts to read the "PIPELINE" setting, but ends up reading the setting for django-pipeline instead and consequently breaks my site.
Rather than call the setting dict for pipeline 'PIPELINE', can this be made customizable in a way that it doesn't break existing projects using django-pipeline? Is there any other way around this?

dedayoa added a commit to dedayoa/django-pipeline that referenced this issue Nov 16, 2020
This update is a potential improvement to work around issues such as jazzband#734.
dedayoa added a commit to dedayoa/django-pipeline that referenced this issue Nov 19, 2020
This update is a potential improvement to work around issues such as jazzband#734
@fdemmer
Copy link

fdemmer commented May 24, 2024

I mean no disrespect, but I don't think this is true:

turns out that djano-social-auth has a setting discovery mechanism that attempts to read the "PIPELINE" setting [...]

Since I am also using both django-pipeline and django-social-auth and never had this problem, I investigated a little...

Quoting the docs you linked:

Almost all settings are prefixed with SOCIAL_AUTH_, there are some exceptions for Django framework like AUTHENTICATION_BACKENDS.

And python-social-auth source confirms the use of a setting_name() function using the SETTING_PREFIX variable, which is used to load all settings including the "PIPELINE".

Is it possible you have overwritten some of that in a custom strategy?

In any case, my 2 cents, I'd vote for closing this and the PR as not reproducable and not a necessary change to django-pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants