Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sub parameter in SD-JWT-VC #276

Closed
fmarino-ipzs opened this issue May 10, 2024 · 0 comments · Fixed by #277
Closed

sub parameter in SD-JWT-VC #276

fmarino-ipzs opened this issue May 10, 2024 · 0 comments · Fixed by #277
Assignees
@fmarino-ipzs
Labels
bug Something isn't working
Milestone
0.7.0

Comments

@fmarino-ipzs
Copy link
Collaborator

According to draft-ietf-oauth-sd-jwt-vc-02 the claim sub is

The identifier of the Subject of the Verifiable Credential. The Issuer MAY use it to provide the Subject identifier known by the Issuer.

We should fix it in the section PID/(Q)EAA SD-JWT parameters
@fmarino-ipzs fmarino-ipzs added the bug Something isn't working label May 10, 2024
@fmarino-ipzs fmarino-ipzs added this to the 0.7.0 milestone May 10, 2024
@fmarino-ipzs fmarino-ipzs self-assigned this May 10, 2024
peppelinux added a commit that referenced this issue May 13, 2024
@peppelinux
fix: sd-jwt vc sub value
a2a6555 
This PR aims to resolve the issue #276
@peppelinux peppelinux mentioned this issue May 13, 2024
Merged
@peppelinux peppelinux linked a pull request May 13, 2024 that will close this issue
fix: sd-jwt vc sub value #277
Merged
peppelinux added a commit that referenced this issue May 13, 2024
@peppelinux
fix: sd-jwt vc sub value (#277)
c301196 
* fix: sd-jwt vc sub value

This PR aims to resolve the issue #276

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarino-ipzs fmarino-ipzs

Labels
bug Something isn't working
Projects
EUDI Wallet IT Technical Specifications
Status: Done
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

fix: sd-jwt vc sub value italia/eudi-wallet-it-docs
1 participant
@fmarino-ipzs