Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate deployment to python-nameless #124

Open
ionelmc opened this issue Jul 26, 2019 · 7 comments
Open

Automate deployment to python-nameless #124

ionelmc opened this issue Jul 26, 2019 · 7 comments

Comments

@ionelmc
Copy link
Owner

ionelmc commented Jul 26, 2019

Currently python nameless has just a few branches that I manually build from time to time.

There could be automation to push branches from pylibrary's CI.

However the test projects are ugly (weird values) and env names (that would translate to branch name) are also ugly. I guess that'd be fine.

PRs could build prefixed branch names (@dHannasch).

@ionelmc ionelmc changed the title Automate deployment to python nameless Automate deployment to python-nameless Jul 26, 2019
@ionelmc
Copy link
Owner Author

ionelmc commented Jul 26, 2019

One thing that I do when I manually update python-nameless: I look at all the diffs. That would be pretty hard to do on 100-something branches. Maybe it should be a different repo ...

@dHannasch
Copy link
Collaborator

Hmm...when you did that one pull request a bit ago, this seemed to work fine:

$ openssl aes-256-cbc -K $encrypted_a70d5afca909_key -iv $encrypted_a70d5afca909_iv -in publish-key.enc -out ~/.ssh/publish-key -d

The command "openssl aes-256-cbc -K $encrypted_a70d5afca909_key -iv $encrypted_a70d5afca909_iv -in publish-key.enc -out ~/.ssh/publish-key -d" exited with 0.

But for the later pull requests I've been making, the variable $encrypted_a70d5afca909_iv is undefined:

$ openssl aes-256-cbc -K $encrypted_a70d5afca909_key -iv $encrypted_a70d5afca909_iv -in publish-key.enc -out ~/.ssh/publish-key -d

iv undefined

The command "openssl aes-256-cbc -K $encrypted_a70d5afca909_key -iv $encrypted_a70d5afca909_iv -in publish-key.enc -out ~/.ssh/publish-key -d" exited with 1.

I assume that the $encrypted_a70d5afca909_iv is set somewhere and that's why your build was able to succeed.

I wonder if it could literally have something to do with who makes the pull request...although I don't see how that's possible, since it's ultimately running on the same server either way, so it should still be able to access the secret, I would think. Indeed it's literally the same user account accessing the Travis server, so...yeah, no idea why the secret is inaccessible.

@Querela
Copy link
Contributor

Querela commented Dec 22, 2020

If it's still an issue.

Maybe it's for security reasons, and it is updated/set to not be accessible for pull requests?
It is theoretically possible to make a pull requests that updates the Travis-CI config to dump those private environment variables. And that would be bad. In travis you can specify where those variables can be used, e.g. only the master branch. That should disable it for pull requests, I would guess.

@ionelmc
Copy link
Owner Author

ionelmc commented Dec 22, 2020

This has sorta been solved. Currently there aren't so many branches, master builds and prs should push stuff there. At least if something didn't break with travis, which sadly happens a lot :-)

@Querela
Copy link
Contributor

Querela commented Dec 22, 2020

Ok.
Yes, my travis jobs ran out of memory. Restarting a few days later they worked again ...

The project should probably also move to travis-ci.com, as the .org one will shut down. See

It might be possible that the automatic redirection they wrote about will work but not sure when they will enable it? The repo icons should be updated, I guess?

https://travis-ci.com/github/ionelmc/cookiecutter-pylibrary/builds
(No builds for now.)

@ionelmc
Copy link
Owner Author

ionelmc commented Dec 22, 2020

Yes we have to update the .com stuff soon, it's on my pretty unreliable todo list :-)

@ionelmc
Copy link
Owner Author

ionelmc commented Jan 10, 2021

Travis.com migration should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants