Skip to content
This repository has been archived by the owner on May 19, 2021. It is now read-only.

Code style #17

Open
2 tasks
MarkusH opened this issue Jan 4, 2015 · 3 comments
Open
2 tasks

Code style #17

MarkusH opened this issue Jan 4, 2015 · 3 comments

Comments

@MarkusH
Copy link
Member

MarkusH commented Jan 4, 2015

From @Lyra2108 on September 14, 2014 23:11

  • Make a demo template, which demonstrates, how the code of the templates should look like. It is supposed to give a practical overview above the following questions:
    • How long should a line be at maximum?
    • Where must be a line break and where should/could be one?
    • When do we indent?
    • How many white spaces are used for indentation?
    • How should a jinja command look like?
  • Go through the existing code and change violations of the style rules.

Copied from original issue: svijee/inyoka#17

@MarkusH
Copy link
Member Author

MarkusH commented Jan 4, 2015

From @svijee on September 15, 2014 20:39

@chris34 do your job. NOW! ;-)

@MarkusH
Copy link
Member Author

MarkusH commented Jan 4, 2015

From @chris34 on September 19, 2014 20:17

Notes for myself:

  • include semantic headings and correct existing ones (list to check http://pastebin.com/AperMnj1) atm they are used some kind of randomly. Only possible reason imho: they seem to be too big – but this could be done via less…

Moreover, I have no idea how detailed the Coding Style Guide should be. Include „detailed“ rules like the following, too? (I looked at some existing ones from Google etc. …)


HTML elements should be set in lowercase and no XHTML-notation.

<br>    <!-- Okay -->
<br/>   <!-- Not Okay -->
<br />  <!-- Not Okay -->
<BR>    <!-- Not Okay -->

@MarkusH
Copy link
Member Author

MarkusH commented Jan 4, 2015

From @Lyra2108 on September 22, 2014 6:5

I think that the example is ok for a rule.

@MarkusH MarkusH modified the milestone: OSS Jan 4, 2015
@Lyra2108 Lyra2108 removed this from the OSS milestone May 25, 2015
@Lyra2108 Lyra2108 modified the milestone: Backlog May 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants