Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description for flatJson option #2010

Open
3 tasks done
NamesMT opened this issue Nov 12, 2024 · 0 comments
Open
3 tasks done

Improve description for flatJson option #2010

NamesMT opened this issue Nov 12, 2024 · 0 comments
Labels
Status: Proposal Request for comments

Comments

@NamesMT
Copy link

NamesMT commented Nov 12, 2024

Clear and concise description of the problem

The current description for flatJson option is: "Allow use flat json messages or not", which is not correct.
It's more of "Allow use of nested/mixed flat and hierarchical json", and what the option actually does is recursively transforming any flat key into a hierachical key.

In the current state of vue-i18n, if the json messages is a simple one level deep flat json (a.k.a key:value json), it is not necessary to enable this option and it would save some overhead.

More context:
flatJson will modify the original object passed in and can cause some gotchas.
flatJson can cause confusion with petite-vue-i18n, and if enabled, will broke petite-vue-i18n when working with flat json.

Suggested solution

TBD

Alternative

No response

Additional context

No response

Validations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Proposal Request for comments
Projects
None yet
Development

No branches or pull requests

1 participant