Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to monorepo structure? #42

Open
kazupon opened this issue Oct 21, 2021 · 12 comments
Open

change to monorepo structure? #42

kazupon opened this issue Oct 21, 2021 · 12 comments
Labels
Status: Proposal Request for comments

Comments

@kazupon
Copy link
Member

kazupon commented Oct 21, 2021

vue-i18n-jest should be supported for Vue 2 / Vue 3 and jest 26 / jest 27 like vue-jest.

Originally posted by @kazupon in #38 (comment)

@kazupon
Copy link
Member Author

kazupon commented Oct 22, 2021

@PeterAlfredLee
If you are interested in this issue, you can lead it. :)

@PeterAlfredLee
Copy link
Member

Sure. I will have a look at this first.

@nogic1008
Copy link
Contributor

@kazupon
I've change vue-jest to monorepo in vuejs/vue-jest#360 and vuejs/vue-jest#361, so I can help.

@kazupon
Copy link
Member Author

kazupon commented Oct 26, 2021

@nogic1008
We're glad to hear your comments.
I've just invited intlify organization
you can work on at test-tools team :)

@PeterAlfredLee
Copy link
Member

Hi @nogic1008 @kazupon
I have pushed a new branch mono_repo. Please have a look.

@kazupon
Copy link
Member Author

kazupon commented Nov 2, 2021

@PeterAlfredLee
Thanks!

Based on the monorepo you prepared, I think we should prepare one for each version of jest 26/27, like vue-jest.

For the Vue 2 / Vue 3 version, I think vue-i18n-jest can support it with monorepo.
Because we can use the version. for example, [email protected] is Vue 2 and [email protected] is Vue 3.

@nogic1008
What do you think about it?

@nogic1008

This comment has been minimized.

Copy link
Member Author

kazupon commented Nov 10, 2021

@nogic1008
Thank you for your advice comment!

I think jest@v28 have not been released yet 😅
So, I think vue version matrix of jest version is like this:

vue-jest vue-i18n-jest
@vue/[email protected] @intlify/vue2-i18n-jest@26
@vue/[email protected] @intlify/vue3-i18n-jest@26
@vue/[email protected] @intlify/vue2-i18n-jest@27
@vue/[email protected] @intlify/vue2-i18n-jest@27

@nogic1008

This comment has been minimized.

Copy link
Member Author

kazupon commented Nov 11, 2021

@nogic1008
Thanks!
Your matrix is very easy to understand.
I think the monorepo structure is no issue it.

Now, we need to get this PR merged.
I sent this PR a few months ago, maybe we need additional work for this PR.
vuejs/vue-jest#364

@nogic1008
Copy link
Contributor

@kazupon
@vue/vueN-jest@26 has been released, and vuejs/vue-jest#364 has been merged.
so matrix is now:

vue jest vue-jest vue-i18n-jest
2.x 26.x @vue/[email protected] @intlify/vue2-i18n-jest@26
3.x 26.x none (@vue/[email protected] does not support custom block) none
2.x 27.x @vue/[email protected] @intlify/vue2-i18n-jest@27
3.x 27.x @vue/vue3-jest@^27.0.0-alpha.4 @intlify/vue2-i18n-jest@27

@kazupon
Copy link
Member Author

kazupon commented Nov 29, 2021

@nogic1008
Thank you for your mentioning!
For me, the matrix makes sense
Okay, Let's try to go next step!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Proposal Request for comments
Projects
None yet
Development

No branches or pull requests

3 participants