From 8bedde1a45d31b3fff8caff90f313eadf417d388 Mon Sep 17 00:00:00 2001 From: Samir Nasibli Date: Wed, 2 Oct 2024 03:20:56 -0700 Subject: [PATCH 1/2] ENH: array api dispatching added array-api-compat to test env --- requirements-test.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/requirements-test.txt b/requirements-test.txt index d9de92c2da..8cc7049d33 100644 --- a/requirements-test.txt +++ b/requirements-test.txt @@ -11,4 +11,5 @@ xgboost==2.1.1 lightgbm==4.5.0 catboost==1.2.7 ; python_version < '3.11' # TODO: Remove 3.11 condition when catboost supports numpy 2.0 shap==0.46.0 +array-api-compat==1.8.0 array-api-strict==2.0.1 From b11fcf3c3e5e4b61116039f748f84405bfbc5f0c Mon Sep 17 00:00:00 2001 From: Samir Nasibli Date: Fri, 4 Oct 2024 05:18:57 -0700 Subject: [PATCH 2/2] Deselect some scikit-learn Array API tests --- deselected_tests.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/deselected_tests.yaml b/deselected_tests.yaml index 4f10264586..e658ad0ae2 100755 --- a/deselected_tests.yaml +++ b/deselected_tests.yaml @@ -25,6 +25,12 @@ # will exclude deselection in versions 0.18.1, and 0.18.2 only. deselected_tests: + # Array API support + # sklearnex functional Array API support doesn't guaranty namespace consistency for the estimator's array attributes. + - decomposition/tests/test_pca.py::test_pca_array_api_compliance[PCA(n_components=2,svd_solver='covariance_eigh')-check_array_api_input_and_values-array_api_strict-None-None] + - decomposition/tests/test_pca.py::test_pca_array_api_compliance[PCA(n_components=2,svd_solver='covariance_eigh',whiten=True)-check_array_api_input_and_values-array_api_strict-None-None] + - linear_model/tests/test_ridge.py::test_ridge_array_api_compliance[Ridge(solver='svd')-check_array_api_input_and_values-array_api_strict-None-None] + # 'kulsinski' distance was deprecated in scipy 1.11 but still marked as supported in scikit-learn < 1.3 - neighbors/tests/test_neighbors.py::test_kneighbors_brute_backend[float64-kulsinski] <1.3 - neighbors/tests/test_neighbors.py::test_radius_neighbors_brute_backend[kulsinski] <1.3