Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject the payload cache into the uploader #593

Open
jbmorley opened this issue May 8, 2023 · 0 comments
Open

Inject the payload cache into the uploader #593

jbmorley opened this issue May 8, 2023 · 0 comments
Labels
ios Impacts the iOS app refactor Code change with no direct user facing impact
Milestone
iOS Future

Comments

@jbmorley
Copy link
Collaborator

jbmorley commented May 8, 2023

Right now the cache is stored on Config and a new instance is instantiated on every upload. This breaks the config lifecycle and the code should be updated to either inject the config instance at upload time, or move the cache elsewhere.
@jbmorley jbmorley added ios Impacts the iOS app refactor Code change with no direct user facing impact labels May 8, 2023
@jbmorley jbmorley modified the milestones: iOS 1.0.0, iOS Future May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ios Impacts the iOS app refactor Code change with no direct user facing impact
Projects
None yet
Milestone
iOS Future
Development

No branches or pull requests
1 participant
@jbmorley