Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our tests that use fixtures #1422

Open
bugarela opened this issue Apr 8, 2024 · 1 comment
Open

Improve our tests that use fixtures #1422

bugarela opened this issue Apr 8, 2024 · 1 comment

Comments

@bugarela
Copy link
Collaborator

bugarela commented Apr 8, 2024

Ideas:

  1. Format test fixture json file as suggested by @p-offtermatt in Parse the empty tuple type #1421 (review), this would make the diffs much easier to read (currently impossible to read)
  2. Use a proper snapshot lib to handle these.
@bugarela
Copy link
Collaborator Author

bugarela commented Sep 9, 2024

We could take advantage of jd, which shows formatted json difference:

git show main:quint/testFixture/_1016nonConstOverride.json | jd testFixture/_1016nonConstOverride.json
@ ["table","8","id"]
- 6
+ 2

But we should first check if there are any snapshot tools - I want to avoid having to maintain the tool in house, even if its simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant