Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port #23396 to main-2.x #25337

Open
gwossum opened this issue Sep 16, 2024 · 0 comments
Open

Port #23396 to main-2.x #25337

gwossum opened this issue Sep 16, 2024 · 0 comments
Assignees
@gwossum
Labels
area/tsm area/2.x OSS 2.0 related issues and PRs

Comments

@gwossum
Copy link
Member

gwossum commented Sep 16, 2024

Port #23396 to main-2.x
@gwossum gwossum added area/tsm area/2.x OSS 2.0 related issues and PRs labels Sep 16, 2024
@gwossum gwossum self-assigned this Sep 16, 2024
gwossum added a commit that referenced this issue Sep 16, 2024
@gwossum
fix: do not rename files on mmap failure
857c020 
If NewTSMReader() fails because mmap fails, do not
rename the file, because the error is probably
caused by vm.max_map_count being too low

Closes: #25337

(cherry picked from commit ec412f7)
@gwossum gwossum mentioned this issue Sep 16, 2024
Merged
gwossum added a commit that referenced this issue Sep 17, 2024
@gwossum
fix: do not rename files on mmap failure (#25340)
5aff511 
If NewTSMReader() fails because mmap fails, do not
rename the file, because the error is probably
caused by vm.max_map_count being too low

Closes: #25337

(cherry picked from commit ec412f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gwossum gwossum

Labels
area/tsm area/2.x OSS 2.0 related issues and PRs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gwossum