Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic.AllLabels is not safe #550

Open
nathanielc opened this issue Dec 17, 2018 · 1 comment
Open

semantic.AllLabels is not safe #550

nathanielc opened this issue Dec 17, 2018 · 1 comment

Comments

@nathanielc
Copy link
Contributor

See https://github.com/influxdata/flux/blob/master/semantic/label_set.go#L9

It is possible to define a label of -all- on an object once we support string literals as object labels.

We can no longer use a sentinel value unless we use an non UTF-8 sequence which I am not sure is safe.

We need to find a solution to this problem. Originally we tried to use nil as the sentinal value for the entire array, but that was extremely error prone. Perhaps LabelSet needs to be a struct.

Copy link

github-actions bot commented Oct 1, 2024

This issue has had no recent activity and will be closed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant