Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for coloring of ChEBI Modified Base Codes #1563

Open
marcus1487 opened this issue Sep 6, 2024 · 5 comments
Open

Support for coloring of ChEBI Modified Base Codes #1563

marcus1487 opened this issue Sep 6, 2024 · 5 comments

Comments

@marcus1487
Copy link

It is currently possible to select the color for the reserved modified base codes, but all of the other values are lumped into the same "other" color code. At nanopore we are working on the release of modified base callers for inosine and pseudo-uridine. These are both encoded as ChEBI codes and thus display with the same color on IGV. It would be amazing to add support for color codes for specific ChEBI codes. I'm not sure exactly what interface you would use for this, but some type of extendable list with an open text field would seem to make sense. Let me know if some test data would be helpful and I can send over.

@jrobinso
Copy link
Contributor

jrobinso commented Sep 6, 2024

Test data is always helpful. Otherwise I have to mock it up which takes time.

The "user preferences" windows are limited, by design, hand crafting guis for preferences is not sustainable. This makes the task more difficult than it perhaps should be. But yes we should do it, however we should also add defaults for any codes known to be of interest. You mention 2, we could start with those.

@marcus1487
Copy link
Author

I will get you test data shortly. The 3 codes for which we have current or soon to be released models are pseU=17802, inosine=17596 and 4mC=21839. So getting defaults (or at least listing these mods in the preferences panel) would be very helpful in the short term.

@jrobinso
Copy link
Contributor

jrobinso commented Sep 6, 2024

I can do both for the next point release as a short term stopgap. If you would like to suggest color defaults post them here as rgb strings.

@marcus1487
Copy link
Author

There are getting to be too many to have any real meaning. I'd probably just go with the furthest from currently used colors in some logical sense (or start cycling back through the colors). I generally change them to be more aesthetic than the defaults anyways and add legends. Happy with whatever you choose here.

@jrobinso
Copy link
Contributor

Reminder for some test data, when I have it I will add these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants