From 9deb85320d66276688783f7a5dd36ad1516b37d0 Mon Sep 17 00:00:00 2001 From: Ian Guedes Maia Date: Sun, 5 Feb 2023 18:52:54 +0100 Subject: [PATCH 1/2] Add migration guide --- MIGRATION.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 MIGRATION.md diff --git a/MIGRATION.md b/MIGRATION.md new file mode 100644 index 000000000..a908138c0 --- /dev/null +++ b/MIGRATION.md @@ -0,0 +1,18 @@ +# Release Toolkit Migration Guide + +--- + +## Migrating to Trunk + +### Considerations for breaking changes + +- Ensure that calls to `ios_bump_version_release` already passed `skip_glotpress: true`. +In case of passing false as parameter or not providing a value (false being the default for this ConfigItem), you'll have to ensure that: + - `download_metadata.swift` isn't being used; if it is, it's a good time to migrate to the new tooling + - You're not relying on `ios_bump_version_release` for commiting the `.po/.pot` file +- The deprecated actions `ios_localize_project` and `ios_update_metadata` were now completely removed. If your project is still using it, please use the new tooling instead. +See `ios_generate_strings_file_from_code`, `ios_extract_keys_from_strings_files`, `ios_download_strings_files_from_glotpress` and `ios_merge_strings_files`. + +### Clean-ups + +- You can now delete the `ENV['APP_STORE_STRINGS_FILE_NAME']` from your Fastfile, as it isn't being used anymore. From a201022b9bb8b638c357593f817f609d4e54f650 Mon Sep 17 00:00:00 2001 From: Ian Guedes Maia Date: Fri, 10 Feb 2023 18:24:21 +0100 Subject: [PATCH 2/2] Update MIGRATION.md Co-authored-by: Olivier Halligon --- MIGRATION.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MIGRATION.md b/MIGRATION.md index a908138c0..63bf9b00d 100644 --- a/MIGRATION.md +++ b/MIGRATION.md @@ -10,8 +10,8 @@ In case of passing false as parameter or not providing a value (false being the default for this ConfigItem), you'll have to ensure that: - `download_metadata.swift` isn't being used; if it is, it's a good time to migrate to the new tooling - You're not relying on `ios_bump_version_release` for commiting the `.po/.pot` file -- The deprecated actions `ios_localize_project` and `ios_update_metadata` were now completely removed. If your project is still using it, please use the new tooling instead. -See `ios_generate_strings_file_from_code`, `ios_extract_keys_from_strings_files`, `ios_download_strings_files_from_glotpress` and `ios_merge_strings_files`. +- The deprecated actions `ios_localize_project` and `ios_update_metadata` were now completely removed. If your project is still using them, please use the new tooling instead. + - See `ios_generate_strings_file_from_code`, `ios_extract_keys_from_strings_files`, `ios_download_strings_files_from_glotpress` and `ios_merge_strings_files` for typical replacements. ### Clean-ups