Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backwards sync should handle finalized block hash 0x0000..0000 corrrectly #7966

Open
daniellehrner opened this issue Dec 2, 2024 · 0 comments
Open

Backwards sync should handle finalized block hash 0x0000..0000 corrrectly #7966

daniellehrner opened this issue Dec 2, 2024 · 0 comments
Labels
bug Something isn't working P3 Medium (ex: JSON-RPC request not working with a specific client library due to loose spec assumtion) snack Smaller coding task - less than a day for an experienced dev syncing

Comments

@daniellehrner
Copy link
Contributor

During a sync Nimbus sent 0x0000..0000 as finalized block hash and safe block hash. This leads to the following warnings in Besu:

2024-12-02 14:07:02.896+00:00 | ForkJoinPool.commonPool-worker-96 | INFO  | BackwardSyncContext | Backward sync phase 2 of 2, 98.21% completed, imported 931 blocks of at least 948 (current head 21315296, target head 21315313). Peers: 25
2024-12-02 14:07:05.690+00:00 | ForkJoinPool.commonPool-worker-96 | INFO  | TransactionPoolFactory | Node is in sync, enabling transaction handling
2024-12-02 14:07:11.225+00:00 | ForkJoinPool.commonPool-worker-96 | INFO  | BackwardSyncContext | Backward sync phase 2 of 2 completed, imported a total of 947 blocks. Peers: 25
2024-12-02 14:07:11.765+00:00 | ForkJoinPool.commonPool-worker-96 | INFO  | BackwardSyncContext | Backward sync phase 2 of 2 completed, imported a total of 948 blocks. Peers: 25
2024-12-02 14:07:11.765+00:00 | ForkJoinPool.commonPool-worker-96 | INFO  | BackwardSyncAlgorithm | Current backward sync session is done
2024-12-02 14:07:12.444+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.444+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.444+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.444+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.444+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.444+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.444+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.444+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.445+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.446+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.447+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.447+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.447+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.447+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.447+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.447+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.447+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.447+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.447+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.447+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.447+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.447+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:12.448+00:00 | ForkJoinPool.commonPool-worker-96 | WARN  | MergeCoordinator | Internal error, backward sync completed but failed to import finalized block 0x0000000000000000000000000000000000000000000000000000000000000000
2024-12-02 14:07:13.283+00:00 | vert.x-worker-thread-0 | INFO  | AbstractEngineNewPayload | Imported #21,315,314 / 136 tx / 16 ws / 0 blobs / base fee 20.27 gwei / 11,216,089 (37.4%) gas / (0xa177a9b7067c7f69793b3ab116b0529277f9a73d61e7ac97593e0c8b3efd40ca) in 0.354s. Peers: 25
2024-12-02 14:07:26.277+00:00 | vert.x-worker-thread-0 | INFO  | AbstractEngineNewPayload | Imported #21,315,315 / 219 tx / 16 ws / 6 blobs / base fee 19.63 gwei / 17,871,631 (59.6%) gas / (0x3b96c2b40bef9a79c50a62f1e2095d64ac795e87c094fcce22ebbb67997925ff) in 1.161s. Peers: 25

We should check for this edge case and ignore setting the finalized hash after a backwards sync in case it is ZERO.
@daniellehrner daniellehrner added bug Something isn't working syncing snack Smaller coding task - less than a day for an experienced dev labels Dec 2, 2024
@jframe jframe added the P3 Medium (ex: JSON-RPC request not working with a specific client library due to loose spec assumtion) label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P3 Medium (ex: JSON-RPC request not working with a specific client library due to loose spec assumtion) snack Smaller coding task - less than a day for an experienced dev syncing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jframe @daniellehrner