Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to do custom tracing with @opentelemetry/[email protected] when honeycomb references 1.8.0 as a hard dependency #172

Closed
longility opened this issue Jun 14, 2024 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@longility
Copy link

longility commented Jun 14, 2024

We should do something like this and expect consumers to install as peer dependency: https://github.com/open-telemetry/opentelemetry-js/blob/4fa7c1358e84287079a5cba95313d42b50cfcb91/experimental/packages/opentelemetry-sdk-node/package.json#L62-L66

Versions
"@honeycombio/opentelemetry-web": "0.3.0"

Steps to reproduce

  1. install "@opentelemetry/api": "1.9.0" along with the honeycomb version mentioned above
  2. add console.log(trace.getTracerProvider()); after sdk.start() where sdk is an instance of HoneycombWebSDK
  3. you will see that the delegate of the tracer provider does not point to the web tracer.

Additional context
So when we use trace.getTracer('foo') and do custom traces, it is considered a non-recording span because it is using the trace that is referencing 1.9.0 instead of 1.8.0 that the honeycomb lib is using as a hard dependency.

@longility longility added the type: bug Something isn't working label Jun 14, 2024
@wolfgangcodes wolfgangcodes self-assigned this Aug 12, 2024
@wolfgangcodes
Copy link
Contributor

Hi @longility thanks for opening this issue! @opentelemetry/api version was updated to ~1.9.0 in the 0.4.0 release (#180). We are separately tracking separating dependencies and peer dependencies here: #126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants