Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Apply patches/ before creating source tarball, and remove #200

Open
fredemmott opened this issue Aug 23, 2019 · 2 comments
Open

Apply patches/ before creating source tarball, and remove #200

fredemmott opened this issue Aug 23, 2019 · 2 comments

Comments

@fredemmott
Copy link
Contributor

Not doing this immediately to minimize changes while fixing debian-8-jessie

@jjergus
Copy link
Contributor

jjergus commented Oct 25, 2019

should we do this now?

@fredemmott
Copy link
Contributor Author

fredemmott commented Oct 29, 2019

this would still be good, but low-impact...

... on the other hand, if we're patching the source tarballs, it could be a good way to inject the HSL and somewhat higher impact :)

Problem there is testing changes to the HSL itself; HHVM has mechanisms for this (runtime-optional-extensions), but i think we'd need something like __PHPStdLib, but for the HSL, to make the HHIs work

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants