You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.
HHAST_FIXME and HHAST_IGNORE_ERROR were originally intended to mirror HH_FIXME vs HH_IGNORE_ERROR
HH_IGNORE_ERROR has been removed
the 'error' part makes some people feel more uncomfortable suppressing linters than they should; linters should generally be taken as 'this is fishy', not a hard error. There are valid reasons to e.g. await in a loop, and suppressing the linter is better/clearer than refactoring to avoid triggering it
Linters can provide their own override, but that replaces the default set.
I suggest:
changing this to a keyset<string> so that specific linters can add a supported suppression
adding a few more defaults:
HHAST_IGNORE[Classname]: still consistent, but briefer, and doesn't have the negative connotations of FIXME or ERROR
@lint-ignore ClassName: consistent with some other frameworks, and still a low chance of collision - and it doesn't matter if there is a collision
(optional) allow projects to configure their own additional suppression comments for each linter
for example, could support @lint-ignore FacebookInternalLinterName in the HSL
The text was updated successfully, but these errors were encountered:
HHAST_FIXME and HHAST_IGNORE_ERROR were originally intended to mirror HH_FIXME vs HH_IGNORE_ERROR
Linters can provide their own override, but that replaces the default set.
I suggest:
keyset<string>
so that specific linters can add a supported suppressionHHAST_IGNORE[Classname]
: still consistent, but briefer, and doesn't have the negative connotations of FIXME or ERROR@lint-ignore ClassName
: consistent with some other frameworks, and still a low chance of collision - and it doesn't matter if there is a collision@lint-ignore FacebookInternalLinterName
in the HSLThe text was updated successfully, but these errors were encountered: