Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot codegen interface to extend another interface #122

Open
Swahvay opened this issue Dec 9, 2019 · 3 comments
Open

Cannot codegen interface to extend another interface #122

Swahvay opened this issue Dec 9, 2019 · 3 comments
Assignees
@jjergus

Comments

@Swahvay
Copy link

Swahvay commented Dec 9, 2019

There is no setExtends or setExtendsf method on CodegenInterface.
@Swahvay Swahvay changed the title Cannot gen interface that extends another interface Cannot codegen interface to extends another interface Dec 9, 2019
@Swahvay Swahvay changed the title Cannot codegen interface to extends another interface Cannot codegen interface to extend another interface Dec 9, 2019
@fredemmott
Copy link
Contributor

This is provided by ->addInterface(), ->setInterfaces() etc in https://github.com/hhvm/hack-codegen/blob/master/src/CodegenClassWithInterfaces.hack - though it does feel strange that it doesn't match the language syntax.

@jjergus
Copy link
Contributor

jjergus commented Dec 9, 2019

Should we add addExtends and setExtends as aliases (for CodegenInterface only) to those functions?

@fredemmott
Copy link
Contributor

I'm not sure; both really have advantages - this is probably best just to be reviewed when/if it's re-unified with fb www

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjergus jjergus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fredemmott @Swahvay @jjergus