Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please, check & find superflous coerce #986

Open
Anton-Latukha opened this issue Aug 14, 2021 · 1 comment
Open

Please, check & find superflous coerce #986

Anton-Latukha opened this issue Aug 14, 2021 · 1 comment
Labels
good first issue Suggested for someone who is not yet familiar with the codebase refactoring No API breakages. Work that only makes code to be nicer or allows for future functionality

Comments

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Aug 14, 2021

During work on type shifts, the coerce gets sprinkled over the code.

Eventually, when types line-up - some of the coerce sprinkled over the codebase become superfluous (Path -> Path & such).

There probably shouldn't be many of them, but also finding & removing them would make the code not only cleaner also reducing their number - prevents type inference problems during work.

@Anton-Latukha Anton-Latukha added good first issue Suggested for someone who is not yet familiar with the codebase refactoring No API breakages. Work that only makes code to be nicer or allows for future functionality labels Aug 14, 2021
@Anton-Latukha
Copy link
Collaborator Author

Also:
coerce $ <expr> $ coerce is coerce (<expr>).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Suggested for someone who is not yet familiar with the codebase refactoring No API breakages. Work that only makes code to be nicer or allows for future functionality
Projects
None yet
Development

No branches or pull requests

1 participant