Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please, merge the Nix variable name representation #974

Closed
Anton-Latukha opened this issue Jul 16, 2021 · 2 comments
Closed

Please, merge the Nix variable name representation #974

Anton-Latukha opened this issue Jul 16, 2021 · 2 comments

Comments

@Anton-Latukha
Copy link
Collaborator

Expr.Types has:

type VarName = Text

Type.Type has:

type Name = Text

In fact, it is the intuitive best application of a newtype, since that puts the most useful & observable type & code boundary between having a Nix language logic & representation for printing.

Then it is a start on a #973.
@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Jul 16, 2021 •
edited
Loading

It is already done, the patch is under way.

Much more unexpectedly difficult is to lift the VarName into newtype. Boundary needs to be made & regulated over the whole project. I would make one, but it would not be ideal right away, but it would be better than no type boundary between Text <-> VarName.

@Anton-Latukha
Copy link
Collaborator Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Anton-Latukha