Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Oauth Access Tokens #50

Open
mdgreenfield opened this issue Oct 23, 2020 · 5 comments
Open

Support for Oauth Access Tokens #50

mdgreenfield opened this issue Oct 23, 2020 · 5 comments

Comments

@mdgreenfield
Copy link
Contributor

mdgreenfield commented Oct 23, 2020

Requesting a new token endpoint for retrieving access tokens.

Similar to vault-plugin-secrets-gcp, requests to create a Vault role would create the Azure App/ServicePrincipal, store the corresponding client credentials in the plugin's internal storage, and use those same client credentials to generate an oauth access token when a user calls azure/token/:role

By supporting this and allowing Azure API callers to use oauth tokens for authentication we can sidestep the client credentials global replication delay issue brought up in #23. This is because typically the Azure role is created ahead of time in an out-of-band process (either manual or automated) thereby giving client credentials time to replicate globally before a user calls the azure/token/:role endpoint.

@fairclothjm
Copy link
Contributor

Thank you for submitting this request! For others who are interested in this, please stick a 👍 on this issue. We’re currently developing an internal process to review and prioritize feature requests.

@mdgreenfield
Copy link
Contributor Author

Thanks @fairclothjm, I just opened a PR that implements this (I'm not sure why I didn't do that a while back). The PR will certainly need to be rebased and documentation added at a minimum. I'll be away from the computer next week but potentially could look into some of these things the following week.

@fairclothjm
Copy link
Contributor

@mdgreenfield That's great, thanks! Feel free to ping me on this issue when you get it updated!

@mdgreenfield
Copy link
Contributor Author

Hi @fairclothjm, I could use some feedback/thoughts on #147 (comment) if you all get some time.

@shmfb
Copy link

shmfb commented Aug 1, 2024

Hello, are there any updates on this? We would also desperately wait for that feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants