tools/importer-rest-api-specs: switching out (most of) the hand-defined Common IDs for the list now available in hashicorp/go-azure-helpers
#4017
Labels
area/resource-ids
Related to Resource IDs, Parsers and Formatters
enhancement
New feature or request
tool/importer-rest-api-specs
Swagger Data Importer issues
Comments
tombuildsstuff
added
enhancement
Merged
4 tasks
tombuildsstuff
added a commit
that referenced
this issue
Jul 12, 2024
…kage There's a bunch of these, and whilst these'll get replaced in time with #4017 but for now this cleans this up
manicminer
pushed a commit
that referenced
this issue
Oct 1, 2024
…kage There's a bunch of these, and whilst these'll get replaced in time with #4017 but for now this cleans this up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Today to add a new Common ID we need to send a PR to
hashicorp/go-azure-helpers, merge and release that, vendor that into this repository (and downstream dependencies) - and then configure it for detection in this repository.As of
v0.67.0a newcommonids.CommonIds()function is available which returns all of the Common ID types defined withinhashicorp/go-azure-sdk- meaning that the majority of the Common ID functions defined here) should be able to replaced by this new function - meaning that this function will require updatingThis would mean that we no longer need to define the Common IDs twice - and whilst the other steps would still apply (so we'd need to ensure
hashicorp/terraform-provider-azurermandhashicorp/go-azure-sdkhad theirhashicorp/go-azure-helpersdependency updated before this repository) - this'd remove a bunch of duplicated logic.This isn't urgent, and I suspect that we may need to leave a couple of them defined in
importer-rest-api-specs- but it'd be worthwhile to reduce the duplication.The text was updated successfully, but these errors were encountered: