Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give user's eslint configuration precedence for coverage analysis #1008

Open
Nargonath opened this issue May 5, 2021 · 0 comments
Open

Give user's eslint configuration precedence for coverage analysis #1008

Nargonath opened this issue May 5, 2021 · 0 comments
Labels
feature New functionality or improvement

Comments

@Nargonath
Copy link
Member

Nargonath commented May 5, 2021

Support plan

  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: N/A
  • module version: latest
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): whatever project
  • any other relevant information:

What problem are you trying to solve?

@kanongil suggested that instead of relying on babel-eslint directly lab should look beforehand into the project's eslint configuration to check whether the user uses another parser. If that's the case then we'd use this parser for the coverage analysis otherwise if the user didn't declare any parser or has no eslint configuration we'd default to hapi eslint plugin value.

Do you have a new or modified API suggestion to solve the problem?

This doesn't need any change to lab's API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or improvement
Projects
None yet
Development

No branches or pull requests

1 participant