Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

high watermark memory limit exceeded #399

Open
solkpolk opened this issue Jun 11, 2024 · 4 comments
Open

high watermark memory limit exceeded #399

solkpolk opened this issue Jun 11, 2024 · 4 comments

Comments

@solkpolk
Copy link

App Crashes when the cropToolbarDelegate?.didSelectCrop() is spam clicked

Error: Thread 1: EXC_RESOURCE (RESOURCE_TYPE_MEMORY: high watermark memory limit exceeded) (limit=2098 MB)

@guoyingtao
Copy link
Owner

@solkpolk

Apologies for the delayed response.

Typically, when didSelectCrop() is called, the CropViewController should be dismissed, making it unlikely for the crop button to be clicked multiple times in quick succession. However, for specific scenarios where this might still occur, I’ve submitted PR #425, which uses a DebounceButton for the built-in crop button. For users implementing custom UIs, I’ve left the debounce feature to be handled by them.

@titoAtChannel
Copy link

Any idea when this fix will be merged?

@guoyingtao
Copy link
Owner

@titoAtChannel
I haven’t merged the fix yet because I thought it was a low-demand feature. I wanted to wait and see if more people needed it. Did this memory issue occur for you as well?

@titoAtChannel
Copy link

Not yet, though I'm keeping an eye on memory consumption. Will let you know if I see the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants