Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why use training, validation and test set to build vocabulary in build_data.py ? Isn't it information leak ? #94

Open
zhihuacc opened this issue Mar 22, 2021 · 0 comments
Open

Why use training, validation and test set to build vocabulary in build_data.py ? Isn't it information leak ? #94

zhihuacc opened this issue Mar 22, 2021 · 0 comments

Comments

@zhihuacc
Copy link

I'm not sure but I think including test set to build vocabulary is spilling information from test set to training set. If using test set was OK, then why using only training set to build character set in build_data.py ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhihuacc