Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several features to improve compatibility with pidantic #73

Closed
dima-dmytruk23 opened this issue Apr 23, 2022 · 3 comments
Closed

Several features to improve compatibility with pidantic #73

dima-dmytruk23 opened this issue Apr 23, 2022 · 3 comments

Comments

@dima-dmytruk23
Copy link

dima-dmytruk23 commented Apr 23, 2022

@necaris I have some requirements on a project that graphene-pydantic==0.3.0 doesn't support.

  1. In mutations - those fields that were not passed - still come as None. As a result, when parsing a dictionary into a Type[BaseModel], these fields are also passed through and an entry is added to the database with these values. exclude_default, exclude_unset - don't work. It is not correct.
  2. If null comes from the client to the Int field - I get an error. The field must be nullable.
  3. Pass empty strings as null in Output.

I corrected them - #75

@necaris
Copy link
Collaborator

necaris commented Apr 23, 2022

@dima-dmytruk23 if you have fixes for these issues it's definitely worth making a PR!

@dima-dmytruk23
Copy link
Author

@dima-dmytruk23 if you have fixes for these issues it's definitely worth making a PR!

Ok. Created PR.

@dima-dmytruk23
Copy link
Author

@necaris you can see this

graphql-python/graphql-core#170 (comment)

@necaris necaris closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants