Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set background color and text color in gr.Textbox #1698

Closed
abidlabs opened this issue Jul 4, 2022 · 3 comments
Closed

Add ability to set background color and text color in gr.Textbox #1698

abidlabs opened this issue Jul 4, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@abidlabs
Copy link
Member

abidlabs commented Jul 4, 2022

Motivated by this issue: gradio-app/7guis-gradio#2, we'd like to have support for custom background colors and text colors in the Textbox component. If we can update this parameter via Python, this would allow for some nice custom validation as well.

@abidlabs abidlabs added the enhancement New feature or request label Jul 4, 2022
@abidlabs abidlabs added this to the 3.x milestone Jul 4, 2022
@pngwn
Copy link
Member

pngwn commented Jul 6, 2022

I think what would be preferable is a series of 'variants' for the textbox (which come with a set of background + text colors) and then when we do theming, allow these variants to be 'themed' along with everything else. This way we can provide the ability to create 'stand out' boxes (for things like asides, warnings, errors, etc) but still ensure that they work with our existing design.

Where possible, I'd like us to control things like colors, spacing, etc via theming so that users don't need to put on a designer hat in order to create the UIs the want (other than for layouts) but can drop down and make those modification where necessary with themes.

@abidlabs
Copy link
Member Author

abidlabs commented Jul 6, 2022

Makes sense!

@freddyaboulton
Copy link
Collaborator

Closing in favor of #1844 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants