Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only the merchant who posted the listing should get back numPaid and numCompleted when querying for listings. #73

Open
hzxcaryn opened this issue Jun 29, 2020 · 1 comment
Open

Only the merchant who posted the listing should get back numPaid and numCompleted when querying for listings. #73

hzxcaryn opened this issue Jun 29, 2020 · 1 comment
Labels
backend nice-to-have

Comments

@hzxcaryn
Copy link
Collaborator

hzxcaryn commented Jun 29, 2020 •
edited
Loading

Currently callers of the getListing and getAllListings API would get back all fields of the Listing resource. We should limit numPaid and numCompleted fields such that only the merchants who posted the listing can get those information.

Requested by @ifhuang in one of the PR reviews
@karenfrilya97
Copy link
Collaborator

I don't think this feature is necessary, but good to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend nice-to-have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hzxcaryn @karenfrilya97