Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: Misleading Documentation #11305

Open
blagoySimandov opened this issue Dec 18, 2024 · 1 comment
Open

storage: Misleading Documentation #11305

blagoySimandov opened this issue Dec 18, 2024 · 1 comment
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. type: question Request for information or clarification. Not an issue.

Comments

@blagoySimandov
Copy link

blagoySimandov commented Dec 18, 2024 •
edited
Loading

google-cloud-go/storage/storage.go

Line 425 in 1a04baf

// Optional.

In here the ContentType is marked as "Optional", when in fact, if left blank the only content type accepted for the signed url is the empty string (""). To me, optional sounds a bit more like "if you omit it anything goes.", rather than "only empty strings are accepted".
@blagoySimandov blagoySimandov mentioned this issue Dec 18, 2024
Closed
@codyoss codyoss changed the title Misleading Documentation storage: Misleading Documentation Dec 18, 2024
@codyoss codyoss added the api: storage Issues related to the Cloud Storage API. label Dec 18, 2024
@tritone tritone added the type: question Request for information or clarification. Not an issue. label Dec 18, 2024
@tritone
Copy link
Contributor

tritone commented Dec 18, 2024

I think there might be a bug (in our code or yours) based on how I am reading the docs. Left a comment on the PR with details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tritone @codyoss @blagoySimandov