Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner/spansql: NOT NULL protobuf columns concatenate NOT NULL into protobuf type-name #11301

Open
dfinkel opened this issue Dec 17, 2024 · 0 comments · May be fixed by #11279
Open

spanner/spansql: NOT NULL protobuf columns concatenate NOT NULL into protobuf type-name #11301

dfinkel opened this issue Dec 17, 2024 · 0 comments · May be fixed by #11279
Assignees
@harshachinta
Labels
api: spanner Issues related to the Spanner API. triage me I really want to be triaged.

Comments

@dfinkel
Copy link
Contributor

dfinkel commented Dec 17, 2024

client: spanner (spansql specifically)

I introduced protobuf type parsing in #10945, and made the parser overly aggressive, so it concatenates NOTNULL into the protobuf type name rather than setting the relevant bool on the column definition when parsing a CREATE TABLE DDL statement.

#11279 fixes this (and a few other minor bugs).
@dfinkel dfinkel added the triage me I really want to be triaged. label Dec 17, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Dec 17, 2024
@dfinkel dfinkel linked a pull request Dec 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshachinta harshachinta

Labels
api: spanner Issues related to the Spanner API. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(spanner/spansql): PROTO BUNDLE and protobuf type parsing fixes dfinkel/google-cloud-go
2 participants
@dfinkel @harshachinta